Require "url" field to not be empty (#25152)

This commit is contained in:
Joel Challis
2026-04-26 13:48:59 +10:00
committed by GitHub
parent 21c193f77b
commit 7d40a3328f
2 changed files with 2 additions and 12 deletions
+2 -1
View File
@@ -46,7 +46,8 @@
"manufacturer": {"$ref": "./definitions.jsonschema#/text_identifier"}, "manufacturer": {"$ref": "./definitions.jsonschema#/text_identifier"},
"url": { "url": {
"type": "string", "type": "string",
"format": "uri" "format": "uri",
"minLength": 1
}, },
"development_board": { "development_board": {
"type": "string", "type": "string",
-11
View File
@@ -168,14 +168,6 @@ def _handle_invalid_features(kb, info):
return ok return ok
def _handle_invalid_config(kb, info):
"""Check for invalid keyboard level config
"""
if info.get('url') == "":
cli.log.warning(f'{kb}: Invalid keyboard level config detected - Optional field "url" should not be empty.')
return True
def _chibios_conf_includenext_check(target): def _chibios_conf_includenext_check(target):
"""Check the ChibiOS conf.h for the correct inclusion of the next conf.h """Check the ChibiOS conf.h for the correct inclusion of the next conf.h
""" """
@@ -292,9 +284,6 @@ def keyboard_check(kb): # noqa C901
if not _handle_invalid_features(kb, kb_info): if not _handle_invalid_features(kb, kb_info):
ok = False ok = False
if not _handle_invalid_config(kb, kb_info):
ok = False
if not _handle_duplicating_code_defaults(kb, kb_info): if not _handle_duplicating_code_defaults(kb, kb_info):
ok = False ok = False